Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich >= 12.5.1 dependency to setup.cfg #349

Closed
wants to merge 1 commit into from

Conversation

ngerakines
Copy link

This PR adds rich >= 12.5.1 to setup.cfg.

Signed-off-by: Nick Gerakines <[email protected]>
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngerakines
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwhonce
Copy link
Member

jwhonce commented Nov 30, 2023

LGTM

@umohnani8
Copy link
Member

Thanks for the PR @ngerakines! This was fixed in #353 and is being cherry-picked to 4.8 as well. Will close this PR now as the fix is already in

@umohnani8 umohnani8 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants