Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sendQueriesState not async #197

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

axel7083
Copy link
Contributor

Fixes #195

@axel7083 axel7083 mentioned this pull request Jan 30, 2024
1 task
@axel7083 axel7083 requested a review from lstocchi January 30, 2024 14:17
Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 self-assigned this Jan 30, 2024
@axel7083
Copy link
Contributor Author

The PlayGroundManager::updatePlaygroundState should follow the same principle - will be done in a next PR

Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 merged commit 3a9a284 into main Jan 30, 2024
3 checks passed
@axel7083 axel7083 deleted the fix/195-sendQueriesState-not-async branch January 30, 2024 14:36
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sendQueriesState should not by async as we do not want to wait for events to be emitted
3 participants