feat: playground error propagation #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel7083
changed the title
|
cc @slemeur |
feloy
approved these changes
Jan 30, 2024
lstocchi
requested changes
Jan 30, 2024
axel7083
force-pushed
the
feature/playground-error-propagation
branch
from
6014b8f to
a16bce8
Compare
Signed-off-by: axel7083 <[email protected]>
|
Rebased after #197 merged |
lstocchi
reviewed
Jan 30, 2024
Co-authored-by: Luca Stocchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Propagate the http request error to the frontend so the user can have a "sense" of what is happening
podman-playground-error.mp4
Related PR
Fixes #186
Testing