Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nri-memtierd plugin #117

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add nri-memtierd plugin #117

merged 1 commit into from
Sep 29, 2023

Conversation

askervin
Copy link
Collaborator

The nri-memtierd plugin toggles swapping, starts/stops memtierd processes that track and manage memory of containers.

@askervin
Copy link
Collaborator Author

This PR supersedes PR #71.

@marquiz marquiz mentioned this pull request Sep 27, 2023
Closed
@fmuyassarov fmuyassarov mentioned this pull request Sep 28, 2023
Merged
@klihub
Copy link
Collaborator

klihub commented Sep 29, 2023

@askervin Could you fix the go mod deps, They seem to be out of date.

klihub
klihub requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.mod needs updating/tidying. Otherwise I think this looks fine, although I have to admit I only skimmed through it quickly.

marquiz
marquiz reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at the code but some other comments/questions below

cmd/plugins/memtierd/Dockerfile Outdated Show resolved Hide resolved
cmd/plugins/memtierd/Dockerfile Outdated Show resolved Hide resolved
cmd/plugins/memtierd/Dockerfile Outdated Show resolved Hide resolved
cmd/plugins/memtierd/Dockerfile Outdated Show resolved Hide resolved
cmd/plugins/memtierd/test-pod.yaml Outdated Show resolved Hide resolved
deployment/overlays/memtierd/daemonset.yaml Show resolved Hide resolved
test/e2e/files/nri-memtierd-deployment.yaml.in Outdated Show resolved Hide resolved
marquiz
marquiz reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits on documentation, feel free to pick the parts that you like

docs/memory/memtierd.md Outdated Show resolved Hide resolved
docs/memory/memtierd.md Outdated Show resolved Hide resolved
docs/memory/memtierd.md Outdated Show resolved Hide resolved
docs/memory/memtierd.md Outdated Show resolved Hide resolved
@klihub klihub mentioned this pull request Sep 29, 2023
Merged
@klihub klihub self-requested a review September 29, 2023 14:48
@askervin
Add nri-memtierd plugin
19e2a20 
The nri-memtierd plugin toggles swapping, starts/stops memtierd
processes that track and manage memory of containers.

Signed-off-by: Antti Kervinen <[email protected]>
Signed-off-by: Luukas Makila <[email protected]>
@klihub klihub requested a review from marquiz September 29, 2023 14:53
@klihub klihub merged commit 6a8441d into containers:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klihub klihub klihub approved these changes

@marquiz marquiz Awaiting requested review from marquiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askervin @klihub @marquiz