Memory QoS example plugin #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
force-pushed
the
5Qw_memory_qos_example
branch
from
d9b0e12 to
9c74625
Compare
marquiz
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Thanks @askervin for the the new plugin!
I didn't look at the code yet but a few notes outside of that:
- could you integrate the documentation in
docs/instead of a separate readme file - deployment files are missing
- Helm
- kustomize
askervin
force-pushed
the
5Qw_memory_qos_example
branch
2 times, most recently
from
40e0c94 to
659ef33
Compare
|
doc separated, kustomize added. @fmuyassarov is helping with help charts. I'd suggest merging this before the memtierd-nri plugin, so that I can rebase the memtierd-nri plugin on top of this and connect its documentation properly to the "memory plugins" document section that is introduced in this patch. |
klihub
reviewed
Sep 29, 2023
klihub
reviewed
Sep 29, 2023
klihub
reviewed
Sep 29, 2023
klihub
reviewed
Sep 29, 2023
klihub
reviewed
Sep 29, 2023
askervin
force-pushed
the
5Qw_memory_qos_example
branch
3 times, most recently
from
2d85fc8 to
3adb872
Compare
marquiz
approved these changes
Sep 29, 2023
|
@askervin Do you lack a sign-off in some commits ? The DCO check fails. |
Signed-off-by: Antti Kervinen <[email protected]>
askervin
force-pushed
the
5Qw_memory_qos_example
branch
from
3adb872 to
56bd6e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.