Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootc-run target to Makefile #233

Merged
merged 1 commit into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions recipes/common/Makefile.common
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ bootc: quadlet
@echo " * https://github.com/osbuild/bootc-image-builder"
@echo " * https://github.com/containers/podman-desktop-extension-bootc"

.PHONY: bootc-run
bootc-run:
podman run -d --rm --name $(APP)-bootc -p 8080:8501 --privileged \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this, you'd in theory access the application at localhost:8080?

$${AUTH_JSON:+-v $${AUTH_JSON}:/run/containers/0/auth.json} \
$(BOOTC_IMAGE) /sbin/init

.PHONY: bootc-image-builder
bootc-image-builder: bootc
mkdir -p build/store
Expand Down
23 changes: 11 additions & 12 deletions recipes/common/README.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
# Makefile targets

.PHONY: check-model-in-path

| Target | Description |
|----------------------|-------------------------------------------------------------------------------|
|bootc | Create bootable container image for the application |
|bootc-image-builder | Create diskimage from your bootc image to be run on a VM or physical hardware |
|build | Build container image to run your app using Containerfile in app directory |
|clean | Remove contents of the build directory |
|quadlet | Modify quadlet files into the build dir |
|run | Run containerizied app as a container |
| install-chromedriver | Used to testing purposes |
| install-chrome | Used for testing purposes |
| Target | Description |
|-----------------------|-------------------------------------------------------------------------------|
| bootc | Create bootable container image for the application |
| bootc-image-builder | Create diskimage from your bootc image to be run on a VM or physical hardware |
| bootc-run | Run bootable container image as a container |
| build | Build container image to run your app using Containerfile in app directory |
| clean | Remove contents of the build directory |
| install-chrome | Used for testing purposes |
| install-chromedriver | Used to testing purposes |
| quadlet | Modify quadlet files into the build dir |
| run | Run containerizied app as a container |


# Makefile variables
Expand Down