Add bootc-run target to Makefile #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
requested review from
MichaelClifford,
sallyom,
lmilbaum and
cgwalters
as code owners
This will make it easier for users to run bootc container locally for testing purposes. Signed-off-by: Daniel J Walsh <[email protected]>
sallyom
reviewed
Apr 10, 2024
| @@ -80,6 +80,12 @@ bootc: quadlet | |||
| @echo " * https://github.com/osbuild/bootc-image-builder" | |||
| @echo " * https://github.com/containers/podman-desktop-extension-bootc" | |||
|
|
|||
| .PHONY: bootc-run | |||
| bootc-run: | |||
| podman run -d --rm --name $(APP)-bootc -p 8080:8501 --privileged \ | |||
There was a problem hiding this comment.
with this, you'd in theory access the application at localhost:8080?
sallyom
reviewed
Apr 10, 2024
There was a problem hiding this comment.
this works for me - the way I've been using it is with the Makefile.common file:
cd recipes/common
make -f Makefile.common BOOTC_IMAGE=quay.io/sallyom/summarizer-bootc:latest APP=summarizer bootc-run
in that case the APP doesn't have an obvious purpose - so maybe add a NAME and set to be either APP if that's set or some default so that if running from common directory you don't need to set APP or NAME that at all
|
You should do this in the summarizor directory and it should work. As far as the 8080, this is what the default demonstration in the bifrost doc said. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier for users to run bootc container locally for testing purposes.