Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure rotation of files based on rotation intervals #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure rotation of files based on rotation intervals #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/io/confluent/connect/hdfs/TopicPartitionWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,9 @@ public boolean recover() {
private void updateRotationTimers(SinkRecord currentRecord) {
long now = time.milliseconds();
// Wallclock-based partitioners should be independent of the record argument.
lastRotate = isWallclockBased
lastRotate = isWallclockBased || currentRecord == null
? (Long) now
: currentRecord != null ? timestampExtractor.extract(currentRecord) : null;
: timestampExtractor.extract(currentRecord);
if (log.isDebugEnabled() && rotateIntervalMs > 0) {
log.debug(
"Update last rotation timer. Next rotation for {} will be in {}ms",
Expand Down Expand Up @@ -600,10 +600,10 @@ private void setState(State state) {
}

private boolean shouldRotateAndMaybeUpdateTimers(SinkRecord currentRecord, long now) {
Long currentTimestamp = null;
if (isWallclockBased) {
Long currentTimestamp;
if (isWallclockBased || currentRecord == null) {
currentTimestamp = now;
} else if (currentRecord != null) {
} else {
currentTimestamp = timestampExtractor.extract(currentRecord);
lastRotate = lastRotate == null ? currentTimestamp : lastRotate;
}
Expand Down