Ensure rotation of files based on rotation intervals #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By falling back to wallclock time when there is no record (i.e. when the upstream `DataWriter` calls `write()`, when the buffer is empty) we initiate a rotation of tmp files to committed files if any of the time intervals trigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#329
Solution
By falling back to wallclock time when there is no record (i.e. when the upstream
DataWritercallswrite()while the buffer is empty) we initiate a rotation of tmp files to committed files if any of the time intervals trigger.This change implies that we are not guaranteed to produce the same output for the same messages (i.e. replaying a topic). Replaying would, however, require one to delete all committed files and the WAL, as the connector uses those to persist offsets, thus by itself this is not a concern.