Try unskipping the previously flakey libvirt tests to check them #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhorsman
added
test_e2e_libvirt
stevenhorsman
added
test_e2e_libvirt
stevenhorsman
force-pushed
the
unskip-libvirt-tests
branch
5 times, most recently
from
e2107a8 to
179202d
Compare
Unskipping the previously flakey libvirt tests. We've had some code fixes in kata and environmental changes that might have helped improve the stability of these tests. Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
unskip-libvirt-tests
branch
from
179202d to
271ea53
Compare
stevenhorsman
changed the title
|
Over the course of testing and rebasing this PR I think I've run the e2e tests around 10 times and other than the couple of tests that I left skipped I haven't seen any failures. Of course I might have got lucky, but I think it's worth re-enabling these if they are stable now. |
mkulke
approved these changes
Dec 11, 2024
wainersm
approved these changes
Dec 11, 2024
|
Merged, lets see how this goes 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work through the skipped libvirt tests to see if they are more stable now...