Skip to content

Commit

Permalink
tests/e2e: libivrt: Unskip tests
Browse files Browse the repository at this point in the history
Unskipping the previously flakey libvirt tests. We've had some code
fixes in kata and environmental changes that might have helped
improve the stability of these tests.

Signed-off-by: stevenhorsman <[email protected]>
  • Loading branch information
stevenhorsman committed Dec 11, 2024
1 parent b79b771 commit b9679f0
Showing 1 changed file with 1 addition and 18 deletions.
19 changes: 1 addition & 18 deletions src/cloud-api-adaptor/test/e2e/libvirt_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ func TestLibvirtCreateSimplePod(t *testing.T) {
}

func TestLibvirtCreatePodWithConfigMap(t *testing.T) {
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePodWithConfigMap(t, testEnv, assert)
}
Expand Down Expand Up @@ -62,25 +61,16 @@ func TestLibvirtCreatePeerPodAndCheckUserLogs(t *testing.T) {
}

func TestLibvirtCreatePeerPodAndCheckWorkDirLogs(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckWorkDirLogs(t, testEnv, assert)
}

func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageOnly(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckEnvVariableLogsWithImageOnly(t, testEnv, assert)
}

func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly(t, testEnv, assert)
}
Expand All @@ -94,20 +84,15 @@ func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageAndDeployment(t *te
}

func TestLibvirtCreateNginxDeployment(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/2046
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestNginxDeployment(t, testEnv, assert)
}

/*
Failing due to issues will pulling image (ErrImagePull)
func TestLibvirtCreatePeerPodWithLargeImage(t *testing.T) {
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodWithLargeImage(t, testEnv, assert)
}
*/

func TestLibvirtDeletePod(t *testing.T) {
assert := LibvirtAssert{}
Expand All @@ -116,7 +101,6 @@ func TestLibvirtDeletePod(t *testing.T) {

func TestLibvirtPodToServiceCommunication(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
SkipTestOnCI(t)
if isTestOnCrio() {
t.Skip("Fails with CRI-O (confidential-containers/cloud-api-adaptor#2100)")
}
Expand All @@ -126,7 +110,6 @@ func TestLibvirtPodToServiceCommunication(t *testing.T) {

func TestLibvirtPodsMTLSCommunication(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
SkipTestOnCI(t)
if isTestOnCrio() {
t.Skip("Fails with CRI-O (confidential-containers/cloud-api-adaptor#2100)")
}
Expand Down

0 comments on commit b9679f0

Please sign in to comment.