Add Code Completion #246
Add Code Completion #246
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/Interpreter/Compatibility.h
Outdated
| if (r.find(CC.Prefix) == 0) | ||
| Results.push_back(r); | ||
| #else | ||
| static_assert(0 && "CodeCompletion is not implemented in Clang <18!") |
There was a problem hiding this comment.
warning: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals]
static_assert(0 && "CodeCompletion is not implemented in Clang <18!")
^this fix will not be applied because it overlaps with another fix
lib/Interpreter/Compatibility.h
Outdated
| if (r.find(CC.Prefix) == 0) | ||
| Results.push_back(r); | ||
| #else | ||
| static_assert(0 && "CodeCompletion is not implemented in Clang <18!") |
There was a problem hiding this comment.
warning: implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
static_assert(0 && "CodeCompletion is not implemented in Clang <18!")
^this fix will not be applied because it overlaps with another fix
lib/Interpreter/Compatibility.h
Outdated
| if (r.find(CC.Prefix) == 0) | ||
| Results.push_back(r); | ||
| #else | ||
| static_assert(0 && "CodeCompletion is not implemented in Clang <18!") |
There was a problem hiding this comment.
warning: implicit conversion 'const char *' -> bool [readability-implicit-bool-conversion]
| static_assert(0 && "CodeCompletion is not implemented in Clang <18!") | |
| static_assert(0 && true) |
| } | ||
|
|
||
| TEST(CodeCompletionTest, Sanity1) { | ||
| std::vector<std::string> cc; |
There was a problem hiding this comment.
warning: variable 'cc' is not initialized [cppcoreguidelines-init-variables]
| std::vector<std::string> cc; | |
| std::vector<std::string> cc = 0; |
alexander-penev
force-pushed
the
AddCodeCompletion
branch
from
3ae810c to
79f24cc
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
alexander-penev
force-pushed
the
AddCodeCompletion
branch
from
75a7711 to
9eb7cad
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 87.65% 79.53% -8.13%
==========================================
Files 4 8 +4
Lines 1742 3015 +1273
==========================================
+ Hits 1527 2398 +871
- Misses 215 617 +402
... and 5 files with indirect coverage changes
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
| @@ -1,11 +1,15 @@ | |||
| #include "clang/Interpreter/CppInterOp.h" | |||
|
|
|||
| #include "clang/Basic/Version.inc" | |||
|
|
|||
| #include "llvm/ADT/SmallString.h" | |||
| #include "llvm/Support/Path.h" | |||
|
|
|||
| #include <gmock/gmock.h> | |||
There was a problem hiding this comment.
warning: 'gmock/gmock.h' file not found [clang-diagnostic-error]
#include <gmock/gmock.h>
^
alexander-penev
force-pushed
the
AddCodeCompletion
branch
2 times, most recently
from
c8cb745 to
1a42ae5
Compare
alexander-penev
force-pushed
the
AddCodeCompletion
branch
from
85d07da to
1144e74
Compare
alexander-penev
force-pushed
the
AddCodeCompletion
branch
from
c9fbc35 to
2d6abe0
Compare
No description provided.