Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

FS-3431 refactored to use sqs funcs from fsd-utils #313

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

RamuniN
Copy link
Contributor

@RamuniN RamuniN commented Oct 28, 2023

https://dluhcdigital.atlassian.net/browse/FS-3431

Description

Refactored to use SQS funtions from fsd-utils

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

Linked PR's
communitiesuk/funding-service-design-application-store#244
communitiesuk/funding-service-design-docker-runner#52

How to test

  • Checkout this branch and the application-store & docker-runner
  • Rebuild the containers with --no-cache
  • Submit an application (from CYP/NSTF or COF R3w2) and observe the application automatically imported to the assessment

Screenshots of UI changes (if applicable)

@RamuniN RamuniN temporarily deployed to Dev October 28, 2023 00:37 — with GitHub Actions Inactive
@RamuniN RamuniN temporarily deployed to Dev October 30, 2023 12:25 — with GitHub Actions Inactive
@RamuniN RamuniN temporarily deployed to Dev October 30, 2023 12:28 — with GitHub Actions Inactive
@RamuniN RamuniN temporarily deployed to Dev October 30, 2023 12:34 — with GitHub Actions Inactive
@RamuniN RamuniN temporarily deployed to Dev October 30, 2023 12:36 — with GitHub Actions Inactive
@RamuniN RamuniN marked this pull request as ready for review October 30, 2023 12:41
Copy link
Contributor

@tferns tferns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 nice one

tests/test_import_queue.py Show resolved Hide resolved
tests/test_import_queue.py Show resolved Hide resolved
tests/test_import_queue.py Show resolved Hide resolved
@RamuniN RamuniN merged commit e478fe9 into main Oct 31, 2023
13 checks passed
@RamuniN RamuniN deleted the FS-3431-use-sqs-from-utils branch October 31, 2023 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants