Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

FS-3431 refactored to use sqs funcs from fsd-utils #244

Merged
merged 2 commits into from
Oct 31, 2023
Merged

FS-3431 refactored to use sqs funcs from fsd-utils #244

merged 2 commits into from
Oct 31, 2023

Conversation

RamuniN
Copy link
Contributor

@RamuniN RamuniN commented Oct 28, 2023 •
edited
Loading

https://dluhcdigital.atlassian.net/browse/FS-3431

Description

Refactored to use SQS funtions from fsd-utils

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

Linked PR's
communitiesuk/funding-service-design-assessment-store#313
communitiesuk/funding-service-design-docker-runner#52

How to test

  • Checkout this branch and the assessment-store & docker-runner
  • Rebuild the containers with --no-cache
  • Submit an application (from CYP/NSTF or COF R3w2) and observe the application automatically imported to the assessment

@RamuniN RamuniN temporarily deployed to Dev October 28, 2023 00:38 — with GitHub Actions Inactive
@RamuniN RamuniN temporarily deployed to Dev October 30, 2023 12:27 — with GitHub Actions Inactive
@RamuniN RamuniN temporarily deployed to Dev October 30, 2023 12:29 — with GitHub Actions Inactive
@RamuniN RamuniN mentioned this pull request Oct 30, 2023
Merged
3 tasks
@RamuniN RamuniN marked this pull request as ready for review October 30, 2023 12:42
tferns
tferns approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@tferns tferns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change, I like the SQS CLIENT class you have made in utils!

.env.development Show resolved Hide resolved
api/routes/application/routes.py Show resolved Hide resolved
@RamuniN RamuniN merged commit 8fdf5ec into main Oct 31, 2023
13 checks passed
@RamuniN RamuniN deleted the FS-3431-use-sqs-from-utils branch October 31, 2023 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tferns tferns tferns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RamuniN @tferns