Fix ProvisioningProfile.team_identifier type interface

CHANGELOG.md

@@ -1,3 +1,9 @@
+Version 0.54.4
+-------------
+
+**Bugfixes**
+- Fix `team_identifier` property on `codemagic.models.ProvisioningProfile` to always return a string as the type hint suggests. [PR #440](https://github.com/codemagic-ci-cd/cli-tools/pull/440)
+
 Version 0.54.3
 -------------
 

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "codemagic-cli-tools"
-version = "0.54.3"
+version = "0.54.4"
 description = "CLI tools used in Codemagic builds"
 readme = "README.md"
 authors = [

src/codemagic/__version__.py

@@ -1,5 +1,5 @@
 __title__ = "codemagic-cli-tools"
 __description__ = "CLI tools used in Codemagic builds"
-__version__ = "0.54.3.dev"
+__version__ = "0.54.4.dev"
 __url__ = "https://github.com/codemagic-ci-cd/cli-tools"
 __licence__ = "GNU General Public License v3.0"

src/codemagic/models/provisioning_profile.py

@@ -86,7 +86,8 @@ def uuid(self) -> str:
 
     @property
     def team_identifier(self) -> str:
-        return self._plist.get("TeamIdentifier", [None])[0]
+        team_identifiers = self._plist.get("TeamIdentifier") or [""]
+        return team_identifiers[0]
 
     @property
     def team_name(self) -> str:

tests/models/test_provisioning_profile.py

@@ -42,3 +42,18 @@ def test_profile_creation_date(provisioning_profile):
 def test_profile_expiration_date(provisioning_profile):
     expected_expiration_date = datetime(2023, 3, 24, 10, 2, 42, tzinfo=timezone.utc)
     assert provisioning_profile.expiration_date == expected_expiration_date
+
+
+@pytest.mark.parametrize(
+    "profile_plist",
+    (
+        {},
+        {"TeamIdentifier": []},
+        {"TeamIdentifier": None},
+        {"TeamIdentifier": ""},
+        {"TeamIdentifier": [""]},
+    ),
+)
+def test_missing_team_identifier(profile_plist):
+    provisioning_profile = ProvisioningProfile(profile_plist)
+    assert provisioning_profile.team_identifier == ""