Fix ProvisioningProfile.team_identifier type interface
#440
+25
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fran-tirapu
approved these changes
Nov 18, 2024
priitlatt
deleted the
bugfix/provisioning-profile-default-team-identifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are provisioning profiles which do not have a
TeamIdentifierkey in theirplist. CurrentlyProvisioningProfile.team_identifierproperty returnsNonein this case, which is conflicting with the type signature of this property. That can cause third party usages to fail that expect that the value of this property is alwaysstr. As with missing team name, default to empty string instead ofNonein case of missing value.Note that is doesn't seem to be possible to generate such profiles any more and those are just remnants from past.