Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CR-23481-cf-notifications-values #73

Merged
merged 10 commits into from
May 13, 2024
Merged

CR-23481-cf-notifications-values #73

merged 10 commits into from
May 13, 2024

Conversation

noam-codefresh
Copy link

@noam-codefresh noam-codefresh commented May 12, 2024 •
edited
Loading

add .Values.codefresh.promotions.notifications overrides to argocd-notifications-cm

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@noam-codefresh noam-codefresh self-assigned this May 12, 2024
@noam-codefresh noam-codefresh merged commit ea155a8 into argo-cd May 13, 2024
2 checks passed
@noam-codefresh noam-codefresh deleted the CR-23481-cf-notifications-values branch May 13, 2024 06:18
noam-codefresh pushed a commit that referenced this pull request May 15, 2024
@ATGardner
Revert "Merge pull request #73 from codefresh-io/CR-23481-cf-notifica…
597f232 
…tions-values"

This reverts commit ea155a8, reversing
changes made to 0373193.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-medvedev-codefresh ilia-medvedev-codefresh ilia-medvedev-codefresh approved these changes

Assignees

@noam-codefresh noam-codefresh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noam-codefresh @ilia-medvedev-codefresh @ATGardner