Skip to content

Commit

Permalink
Merge pull request #73 from codefresh-io/CR-23481-cf-notifications-va…
Browse files Browse the repository at this point in the history
…lues

add .Values.codefresh.promotions.notifications overrides to argocd-notifications-cm
  • Loading branch information
ATGardner authored May 13, 2024
2 parents 0373193 + 377d0a0 commit ea155a8
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@ output
.idea
**/*.tgz
**/charts/*/charts

# only ignore the values.yaml file at the root of the repo
/values.yaml
2 changes: 1 addition & 1 deletion charts/argo-cd/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v2.10-2024.3.29-1dcc54e29
kubeVersion: ">=1.23.0-0"
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 6.7.18-cap-2.10-2024.3.29-1dcc54e29
version: 6.7.18-1-cap-2.10-2024.3.29-1dcc54e29
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
sources:
Expand Down
5 changes: 5 additions & 0 deletions charts/argo-cd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,11 @@ NAME: my-release
| apiVersionOverrides | object | `{}` | |
| applicationVersioning.enabled | bool | `true` | enables the Codefresh application versioning feature |
| applicationVersioning.useApplicationConfiguration | bool | `true` | use ApplicationConfiguration CRD to manage application versioning |
| codefresh.promotions.notifications.context | object | `{}` | |
| codefresh.promotions.notifications.notifigers | object | `{}` | |
| codefresh.promotions.notifications.subscriptions | list | `[]` | |
| codefresh.promotions.notifications.templates | object | `{}` | |
| codefresh.promotions.notifications.triggers | object | `{}` | |
| crds.additionalLabels | object | `{}` | Addtional labels to be added to all CRDs |
| crds.annotations | object | `{}` | Annotations to be added to all CRDs |
| crds.install | bool | `true` | Install and upgrade CRDs |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@ metadata:
data:
context: |
argocdUrl: {{ .Values.notifications.argocdUrl | default (printf "https://%s" .Values.global.domain) }}
{{- with .Values.notifications.context }}
{{- with (merge .Values.notifications.context .Values.codefresh.promotions.notifications.context) }}
{{- toYaml . | nindent 4 }}
{{- end }}
{{- with .Values.notifications.notifiers }}
{{- with (merge .Values.notifications.notifiers .Values.codefresh.promotions.notifications.notifiers) }}
{{- toYaml . | nindent 2 }}
{{- end }}
{{- with .Values.notifications.subscriptions }}
{{- with (concat .Values.notifications.subscriptions .Values.codefresh.promotions.notifications.subscriptions) }}
subscriptions: |
{{- toYaml . | nindent 4 }}
{{- end }}
{{- with .Values.notifications.templates }}
{{- with (merge .Values.notifications.templates .Values.codefresh.promotions.notifications.templates) }}
{{- toYaml . | nindent 2 }}
{{- end }}
{{- with .Values.notifications.triggers }}
{{- with (merge .Values.notifications.triggers .Values.codefresh.promotions.notifications.triggers) }}
{{- toYaml . | nindent 2 }}
{{- end }}
{{- end }}
9 changes: 9 additions & 0 deletions charts/argo-cd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3821,3 +3821,12 @@ eventReporter:
enabled: false
# -- List of custom rules for the event reporter's ClusterRole resource
rules: []

codefresh:
promotions:
notifications:
context: {}
notifigers: {}
subscriptions: []
templates: {}
triggers: {}

0 comments on commit ea155a8

Please sign in to comment.