React to health_status events #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I triggered two additional /podman-next scenarios. |
|
I apparently fixed the follow-up failure (see #1443), and HealthcheckUser seems stable now. But now there is a new failure in HealthcheckSystem only, which also reproduces locally. Indeed healthcheck events are completely broken now for unhealthy system containers. |
|
I filed containers/podman#20342 about the healthcheck regression. Let's land this to at least make test failures more predictable, and this is a good and necessary bug fix. |
We previously didn't react to `health_status` events as they were broken, and only reacted to `exec_died` instead. With the upcoming podman release, `health_status` events are reliable, and they will also not be accompanied by an `exec_died` event any more. So start updating the container status on them. Still keep listening to `exec_died` to support older podman releases. Fixes cockpit-project#1443
martinpitt
force-pushed
the
fix-healthcheck
branch
from
2aafae4 to
dc581b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously didn't react to
health_statusevents as they were broken, and only reacted toexec_diedinstead. With the upcoming podman release,health_statusevents are reliable, and they will also not be accompanied by anexec_diedevent any more. So start updating the container status on them.Still keep listening to
exec_diedto support older podman releases.Fixes #1443