Skip to content

Commit

Permalink
React to health_status events
Browse files Browse the repository at this point in the history
We previously didn't react to `health_status` events as they were
broken, and only reacted to `exec_died` instead. With the upcoming
podman release, `health_status` events are reliable, and they will also
not be accompanied by an `exec_died` event any more. So start updating
the container status on them.

Still keep listening to `exec_died` to support older podman releases.

Fixes #1443
  • Loading branch information
martinpitt authored and jelly committed Oct 12, 2023
1 parent 1c71490 commit 8e243ad
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/app.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ class Application extends React.Component {
case 'export':
case 'import':
case 'init':
case 'health_status': // HACK: broken, https://github.com/containers/podman/issues/19237; see exec_died
case 'kill':
case 'mount':
case 'prune':
Expand All @@ -360,7 +359,8 @@ class Application extends React.Component {
case 'cleanup':
case 'create':
case 'died':
case 'exec_died': // HACK: pick up health check runs, see https://github.com/containers/podman/issues/19237
case 'exec_died': // HACK: pick up health check runs with older podman versions, see https://github.com/containers/podman/issues/19237
case 'health_status':
case 'pause':
case 'restore':
case 'stop':
Expand Down

0 comments on commit 8e243ad

Please sign in to comment.