Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulse optimisation #7624

Merged
merged 4 commits into from
Nov 20, 2024
Merged

pulse optimisation #7624

merged 4 commits into from
Nov 20, 2024

Conversation

stanalbatross
Copy link
Contributor

@stanalbatross stanalbatross commented Nov 19, 2024

About the pull request

turns out the var checked by like only three things didn't need to be updated every life tick, who knew! thanks baycoders

Explain why it's good for the game

removes a proc called on every carbon from life.dm

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: slightly optimised how pulse is checked by checking it when required rather than every lifetick
/:cl:

@cmss13-ci cmss13-ci bot added the Code Improvement Make the code longer label Nov 19, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tgstation hipsters with implicit src

code/modules/mob/living/carbon/human/human.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/human.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/examine.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft November 19, 2024 13:47
@stanalbatross stanalbatross marked this pull request as ready for review November 19, 2024 13:56
@harryob harryob added this pull request to the merge queue Nov 20, 2024
Merged via the queue into cmss13-devs:master with commit 2bb8409 Nov 20, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants