Xenos no longer have capped damage #7619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
the
Testmerge Candidate
cm13-github
added a commit
that referenced
this pull request
Nov 18, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 18, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 19, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 19, 2024
harryob
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes an oversight where
/mob/living/proc/adjustBruteLossand/mob/living/proc/adjustFireLosscaps brute/fire damage at 2x max health, but warding changes their effective max health resulting in edge cases where the xenomorph is immortal (though forever in crit). Now xenos do not cap their brute or fire damage.Explain why it's good for the game
Fixes #7082
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/I2h1qd5sN8I
Changelog
🆑 Drathek
fix: Fixed xenos sometimes becoming immortal with warding pheros (xenos do not cap brute/fire damage now)
/:cl: