-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Auto Oviable Areas #7507
Merged
Merged
Fix Auto Oviable Areas #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
the
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
label
Nov 5, 2024
cmss13-ci
bot
added
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Fix
Fix one bug, make ten more
labels
Nov 5, 2024
Drulikar
added
the
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
label
Nov 6, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 6, 2024
harryob
approved these changes
Nov 6, 2024
@@ -232,15 +236,11 @@ | |||
return ..() | |||
|
|||
/obj/effect/landmark/xeno_hive_spawn | |||
name = "xeno hive spawn" | |||
name = "xeno vs xeno hive spawn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Fix
Fix one bug, make ten more
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a follow up to #7363 and #7488 where it was discovered that the XvX hive landmarks were being used as an area to allow ovi meaning distress signal was getting areas not intended to be oviable. This also makes it so the ovi restriction does not apply to XvX (all areas will allow it).
Oviable areas were also expanded on Kutjevo, Shivas, Tijent Dam, Chance's Claim, and Fiorina.
Explain why it's good for the game
Ovi restrictions are intended to disallow hives next to LZs, this fixes that. It also expands the areas oviable at the start of the game on Kutjevo, Shivas, Trijent Dam, Chance's Claim, and Fiorina so there is more variety in where an initial hive can be place.
Testing Photographs and Procedure
Screenshots & Videos
Testmerge with Hybrisa:
Changelog
🆑 Drathek
balance: Fix XvX landmarks being used for roundstart oviable locations
balance: Roundstart oviable locations are expanded on Kurjevo, Shivas, Trijent Dam, Chances's Claim, and Fiorina
fix: XvX now makes all areas oviable
/:cl: