Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auto Oviable Areas #7507

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Nov 5, 2024

About the pull request

This PR is a follow up to #7363 and #7488 where it was discovered that the XvX hive landmarks were being used as an area to allow ovi meaning distress signal was getting areas not intended to be oviable. This also makes it so the ovi restriction does not apply to XvX (all areas will allow it).

Oviable areas were also expanded on Kutjevo, Shivas, Tijent Dam, Chance's Claim, and Fiorina.

Explain why it's good for the game

Ovi restrictions are intended to disallow hives next to LZs, this fixes that. It also expands the areas oviable at the start of the game on Kutjevo, Shivas, Trijent Dam, Chance's Claim, and Fiorina so there is more variety in where an initial hive can be place.

Testing Photographs and Procedure

Screenshots & Videos

Soro
Soro_After
Kutjevo
Kutjevo_After
Shivas
Shivas_After
Trijent
Trijent_After
Chances
Chances_After
Fiorina
Fiorina_After
Lv624_After
NV_After
Solaris_After

Testmerge with Hybrisa:
Hybrisa

Changelog

🆑 Drathek
balance: Fix XvX landmarks being used for roundstart oviable locations
balance: Roundstart oviable locations are expanded on Kurjevo, Shivas, Trijent Dam, Chances's Claim, and Fiorina
fix: XvX now makes all areas oviable
/:cl:

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Nov 5, 2024
@cmss13-ci cmss13-ci bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more labels Nov 5, 2024
@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Nov 6, 2024
@@ -232,15 +236,11 @@
return ..()

/obj/effect/landmark/xeno_hive_spawn
name = "xeno hive spawn"
name = "xeno vs xeno hive spawn"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@harryob harryob added this pull request to the merge queue Nov 6, 2024
Merged via the queue into cmss13-devs:master with commit a3e52c2 Nov 6, 2024
30 checks passed
cmss13-ci bot added a commit that referenced this pull request Nov 6, 2024
@Drulikar Drulikar deleted the Fix_Auto_Oviable branch November 6, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants