Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redefinition of EDM_ML_DEBUG in HcalDigitizer.cc #46708

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Remove redefinition of EDM_ML_DEBUG in HcalDigitizer.cc #46708

merged 1 commit into from
Nov 16, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Title says it all.

PR validation:

Bot tests

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_2_DBG_X

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Nov 15, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46708/42665

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • SimCalorimetry/HcalSimProducers (simulation)

@civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@abdoulline, @bsunanda, @mariadalfonso, @rovere, @sameasy this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@iarspider iarspider changed the title Remove definition of EDM_ML_DEBUG in HcalDigitizer.cc Remove redefinition of EDM_ML_DEBUG in HcalDigitizer.cc Nov 15, 2024
@civanch
Copy link
Contributor

civanch commented Nov 15, 2024

+1

the fix is obvious, should not affect any test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor

civanch commented Nov 15, 2024

urgent

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/summary.html
COMMIT: b56a394
CMSSW: CMSSW_14_2_DBG_X_2024-11-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42880/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS
---> test test_MC_22_crosscheck had ERRORS

RelVals

----- Begin Fatal Exception 15-Nov-2024 14:48:03 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29696.0_CloseByPGun_CE_E_Front_120um+Run4D110


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 15-Nov-2024 14:52:29 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29700.0_CloseByPGun_CE_H_Coarse_Scint+Run4D110


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 15-Nov-2024 18:15:56 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/memorymodules_hourglassExtendedAllCombined.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42880/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29634.75_TTbar_14TeV+Run4D110_HLT75e33Timing


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Types.py(1001): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(397): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Mixins.py(532): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1217): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_DBG_X_2024-11-14-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@civanch
Copy link
Contributor

civanch commented Nov 15, 2024

Do not know what happens in testing but not related to this PR.

@civanch civanch mentioned this pull request Nov 16, 2024
Merged
@civanch
Copy link
Contributor

civanch commented Nov 16, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac2459/42899/summary.html
COMMIT: b56a394
CMSSW: CMSSW_14_2_X_2024-11-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46708/42899/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343764
  • DQMHistoTests: Total failures: 519
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343225
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a065cc0 into cms-sw:master Nov 16, 2024
15 of 17 checks passed
@iarspider iarspider deleted the patch-12 branch November 16, 2024 21:58
@cmsbuild cmsbuild mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved simulation-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@iarspider @cmsbuild @civanch @mandrenguyen