Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for SubmitPVsplit unit test #46719

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 17, 2024

PR description:

This PR is an attempt to solve part of issue #45751 related to the SubmitPVsplit unit test (see also IB logs).

PR validation:

  • scram b runtests_SubmitPVsplit runs regularly in CMSSW_14_2_X_2024-11-17-0000
  • scram b runtests_SubmitPVsplit runs regularly in CMSSW_14_2_ASAN_X_2024-11-15-2300 without residuals mentions of LeakSanitizer on cmsdev40, albeit it also did run to completion before the changes, thus I cannot be full certain this is a complete fix.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 17, 2024

please test for CMSSW_14_2_ASAN_X

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46719 was updated. @atpathak, @cmsbuild, @consuegs, @perrotta can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 17, 2024

please test for CMSSW_14_2_ASAN_X

@mmusich mmusich marked this pull request as ready for review November 17, 2024 17:02
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bcdaa/42912/summary.html
COMMIT: db24ba3
CMSSW: CMSSW_14_2_ASAN_X_2024-11-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46719/42912/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bcdaa/42912/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bcdaa/42912/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_22_setup had ERRORS
---> test test_MC_23_setup had ERRORS

@mmusich
Copy link
Contributor Author

mmusich commented Nov 18, 2024

Unit test SubmitPVsplit completed successfully see log.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 18, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bcdaa/42917/summary.html
COMMIT: db24ba3
CMSSW: CMSSW_14_2_X_2024-11-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46719/42917/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6c29499 into cms-sw:master Nov 18, 2024
16 of 17 checks passed
@mmusich mmusich deleted the mm_subimitPVResolutionASANX branch November 18, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants