[DQM] Modify DQMGUI upload test to only run in automated environments #46690
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46690/42630 |
|
A new Pull Request was created by @nothingface0 for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
@cmsbuild please abort Didn't notice the "DQMGUI dev not available" part |
nothingface0
force-pushed
the
fix_test_dqmgui_upload
branch
from
b62b37c
to
fee2caf
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46690/42632 |
|
Pull request #46690 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again. |
I.e., when the cmsbot is running the test for PRs or IBs, where `CMSBOT_CI_TESTS` is set. - Also fix the timestamp of the renamed file to include the hour, which was missing before, it will help with debugging. - Added a `--help` argument, just in case. See also: cms-sw#46682
nothingface0
force-pushed
the
fix_test_dqmgui_upload
branch
from
fee2caf
to
fdd94e8
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46690/42633 |
|
Pull request #46690 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again. |
|
@rseidita you can trigger the tests again |
|
please test |
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
|
+1
|
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
After @smuzaffar's recommendation, modify
TestDQMGUIUploadto only run for PRs and IBs, and not for local testing, when theDQMServices/Demopackage is checked out. The test checks for theCMSBOT_CI_TESTSenv var, or a--forceargument, to override the variable.Also fix the timestamp of the renamed file to include the hour, which was missing before, it will help with debugging.
A
--helpargument to print the script's usage is also added.See also: #46682
PR validation:
Tested on LXPLUS. DQMGUI dev is currently unavailable for full testing.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport.