Enhance User Access Token Flow with PR Count Tracking #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….json, modified schema.prisma, app.js, router.js, GithubPassportStrategy.js, and Middlewares.js files"
…mma-backend into mitgajera/main
jalaym825
reviewed
Oct 18, 2024
| // Function to fetch pull request count | ||
| const getPullRequestCount = async (githubId, accessToken) => { | ||
| try { | ||
| const response = await axios.get(`https://api.github.com/search/pulls?q=author:${githubId}+is:public`, { |
There was a problem hiding this comment.
why fetching user's all prs, we don't want his all pr count, we want pr counts of our projects, so you can remove this thing
jalaym825
reviewed
Oct 18, 2024
| // router.post('/logout', controller.logout); // Add logout route | ||
| router.get('/access_token', controller.getAccessToken); // Add access token route | ||
| // GitHub authentication routes | ||
| router.get('/github', passport.authenticate('github', { scope: ['user:email'] })); |
|
hey @mitgajera |
|
@mitgajera good work, but please keep small changes in a single commit and don't include changes which are not relatable to issue, you can create separate issue for that. |
|
@jalaym825 |
|
closing the pr for now, fix all things and raise new pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request (PR) introduces improvements to the user authentication process by including the retrieval and updating of pull request (PR) counts for users during the access token flow.
Issue fixed: #14
Changes Made
getPullRequestCountfunction that retrieves the total count of pull requests authored by the user from GitHub's API.prCountfield, initialized to 0 for new users.getAccessTokenfunction to:Why This Change?
By keeping track of the number of pull requests, we can better evaluate user engagement and contributions within our application. This enhancement will enable us to use this data for analytics and user recognition features in future iterations.
Testing