Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Authentication Flow for PR Count Retrieval #18

Closed
wants to merge 6 commits into from

Conversation

mitgajera
Copy link

@mitgajera mitgajera commented Oct 18, 2024

Overview

This PR refines the user authentication process by focusing on retrieving and updating the number of pull requests (PRs) made by users during the GitHub access token flow. Unnecessary functions and components unrelated to this task were removed for clarity and efficiency.

issue: #14

Removed Unnecessary Functions

  • Removed getUser: Not required for the PR count logic.
  • Removed not required routes
  • Removed logout: Unrelated to the current scope.
  • Removed references to mailer and logger as they are not used in this PR.

Why This Change?

The goal was to streamline the authentication flow and focus on tracking user contributions through their pull requests. By removing unrelated code, the authentication logic is now more efficient, easier to maintain, and aligned with the intended functionality of PR count retrieval.

Testing

  • Manually tested GitHub authentication with both new and existing users.
  • Verified that the PR count is successfully retrieved from GitHub and updated in the database.

@mitgajera mitgajera marked this pull request as draft October 18, 2024 15:21
@mitgajera mitgajera closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant