Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telemetry] wait for all events sent with timeout #7306

Closed
wants to merge 5 commits into from
Closed

[telemetry] wait for all events sent with timeout #7306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b76f15d
feat: add telemetry commands (#7236)
emily-shen Nov 15, 2024
61acb66
feat: add `wrangler metrics` as an alias for `wrangler telemetry` (#7…
emily-shen Nov 18, 2024
10f86fb
feat: send metrics for command start/complete/error (#7267)
emily-shen Nov 19, 2024
4799bba
fix nested properties (#7300)
emily-shen Nov 20, 2024
ee37f8c
wait for all events sent with timeout
edmundhung Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/create-pullrequest-prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ jobs:
run: node .github/prereleases/2-build-pack-upload.mjs
env:
NODE_ENV: "production"
# this is the "test/staging" key for sparrow analytics
SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998"
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
ALGOLIA_PUBLIC_KEY: ${{ secrets.ALGOLIA_PUBLIC_KEY }}
SENTRY_DSN: "https://[email protected]/583"
Expand Down
2 changes: 2 additions & 0 deletions packages/wrangler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
"selfsigned": "^2.0.1",
"source-map": "^0.6.1",
"unenv": "npm:[email protected]",
"which-pm-runs": "^1.1.0",
"workerd": "1.20241106.1",
"xxhash-wasm": "^1.0.1"
},
Expand Down Expand Up @@ -115,6 +116,7 @@
"@types/shell-quote": "^1.7.2",
"@types/signal-exit": "^3.0.1",
"@types/supports-color": "^8.1.1",
"@types/which-pm-runs": "^1.0.0",
"@types/ws": "^8.5.7",
"@types/yargs": "^17.0.22",
"@vitest/ui": "catalog:default",
Expand Down
6 changes: 3 additions & 3 deletions packages/wrangler/scripts/bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ async function buildMain(flags: BuildFlags = {}) {
__RELATIVE_PACKAGE_PATH__,
"import.meta.url": "import_meta_url",
"process.env.NODE_ENV": `'${process.env.NODE_ENV || "production"}'`,
...(process.env.SPARROW_SOURCE_KEY
? { SPARROW_SOURCE_KEY: `"${process.env.SPARROW_SOURCE_KEY}"` }
: {}),
"process.env.SPARROW_SOURCE_KEY": JSON.stringify(
process.env.SPARROW_SOURCE_KEY ?? ""
),
...(process.env.ALGOLIA_APP_ID
? { ALGOLIA_APP_ID: `"${process.env.ALGOLIA_APP_ID}"` }
: {}),
Expand Down
Loading
Loading