Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telemetry] wait for all events sent with timeout #7306

Closed
wants to merge 5 commits into from

Conversation

edmundhung
Copy link
Member

Fixes n/a

This PR will be merged into the wrangler-telemetry branch.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not released yet

emily-shen and others added 5 commits November 19, 2024 14:09
* add telemetry commands

* changeset

* fix and test dates

* update changeset

* add global/project status

* default true

* remove changeset

* update wrangler telemetry status
)

* add metrics alias

* tests

* use each to test alias
* stop collecting userId in telemetry

Co-authored-by: emily-shen <[email protected]>

* implement telemetry collection

* infer errorType based on the constructor name

* implement common event properties

* log common event properties

Co-authored-by: Edmund Hung <[email protected]>

* respect metric enabled/disabled

* remove dispatcher.identify

* include SPARROW_SOURCE_KEY in PR pre-release build

* fix tests

* ensure debug log covers the request failed message

* replace SPARROW_SOURCE_KEY regardless whethe env exists

---------

Co-authored-by: Edmund Hung <[email protected]>
Co-authored-by: emily-shen <[email protected]>
Co-authored-by: Edmund Hung <[email protected]>
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: ee37f8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-wrangler-7306

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7306/npm-package-wrangler-7306

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-wrangler-7306 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-create-cloudflare-7306 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-cloudflare-kv-asset-handler-7306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-miniflare-7306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-cloudflare-pages-shared-7306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-cloudflare-vitest-pool-workers-7306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-cloudflare-workers-editor-shared-7306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-cloudflare-workers-shared-7306
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11942328226/npm-package-cloudflare-workflows-shared-7306

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung changed the base branch from main to wrangler-telemetry November 21, 2024 11:22
@edmundhung
Copy link
Member Author

This is added in #7302

@edmundhung edmundhung closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants