Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align logger names #986

Merged
merged 1 commit into from
Sep 18, 2023
Merged

align logger names #986

merged 1 commit into from
Sep 18, 2023

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Sep 16, 2023

loggers should be named the same throughout the project, if applicable. following the pattern: private static final Logger logger.

@bbortt bbortt self-assigned this Sep 16, 2023
@bbortt bbortt linked an issue Sep 17, 2023 that may be closed by this pull request
Unify naming of loggers in citrus #829
Closed
@bbortt
fix: align logger names
c266570 
loggers should be named the same throughout the project, if applicable.
following the pattern: `private static final Logger logger`.
@bbortt bbortt removed the State: WIP label Sep 17, 2023
@bbortt bbortt changed the title Draft: align logger names align logger names Sep 17, 2023
@tschlat
Copy link
Collaborator

tschlat commented Sep 18, 2023

I luckily survived this. Already bored me to death.
Did not find anything mentionable though.

christophd
christophd approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Many thanks!

@bbortt bbortt merged commit 1a9ea4e into main Sep 18, 2023
1 check passed
@bbortt bbortt deleted the fix/loggers branch September 18, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophd christophd christophd approved these changes

@tschlat tschlat Awaiting requested review from tschlat

Assignees

@bbortt bbortt

Labels
Prio: Medium Type: Maintenance
Projects
Citrus 4.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify naming of loggers in citrus
3 participants
@bbortt @tschlat @christophd