Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify naming of loggers in citrus #829

Closed
tschlat opened this issue Dec 17, 2021 · 2 comments · Fixed by #986
Closed

Unify naming of loggers in citrus #829

tschlat opened this issue Dec 17, 2021 · 2 comments · Fixed by #986

Comments

@tschlat
Copy link
Collaborator

tschlat commented Dec 17, 2021

Citrus Version
3.1 (applies to current version of Citrus-Simulator as well)

Expected behavior
Usage of loggers should be unique over all classes and modules

Actual behavior
Currently loggers are instantiated in different ways:
E.g.

private static final Logger LOG = LoggerFactory.getLogger(TestContext.class);
private static Logger log = LoggerFactory.getLogger(CitrusVersion.class);

I would propose to use the following definition:

private static final Logger log = LoggerFactory.getLogger(CitrusVersion.class);

According to Java Coding Conventions (Chapter 3.3) the log is not a constant and should therefore not be capitalized, although it is static final.

@bbortt
Copy link
Collaborator

bbortt commented Dec 20, 2021

agree on this solution.

@bbortt
Copy link
Collaborator

bbortt commented Jul 19, 2022

in the same turn, we should look to replace usages of String#format with the logger implementation of the parameter replacing.

@bbortt bbortt moved this to Backlog in Citrus 4.0 Jul 27, 2022
@bbortt bbortt self-assigned this Sep 16, 2023
@bbortt bbortt linked a pull request Sep 17, 2023 that will close this issue
@bbortt bbortt removed the State: WIP label Sep 17, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Citrus 4.0 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants