We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Citrus Version 3.1 (applies to current version of Citrus-Simulator as well)
Expected behavior Usage of loggers should be unique over all classes and modules
Actual behavior Currently loggers are instantiated in different ways: E.g.
private static final Logger LOG = LoggerFactory.getLogger(TestContext.class); private static Logger log = LoggerFactory.getLogger(CitrusVersion.class);
I would propose to use the following definition:
private static final Logger log = LoggerFactory.getLogger(CitrusVersion.class);
According to Java Coding Conventions (Chapter 3.3) the log is not a constant and should therefore not be capitalized, although it is static final.
The text was updated successfully, but these errors were encountered:
agree on this solution.
Sorry, something went wrong.
in the same turn, we should look to replace usages of String#format with the logger implementation of the parameter replacing.
String#format
bbortt
Successfully merging a pull request may close this issue.
Citrus Version
3.1 (applies to current version of Citrus-Simulator as well)
Expected behavior
Usage of loggers should be unique over all classes and modules
Actual behavior
Currently loggers are instantiated in different ways:
E.g.
I would propose to use the following definition:
According to Java Coding Conventions (Chapter 3.3) the log is not a constant and should therefore not be capitalized, although it is static final.
The text was updated successfully, but these errors were encountered: