Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Cypress cleanup #8286

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Minor Cypress cleanup #8286

merged 1 commit into from
Apr 3, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Apr 3, 2024 •
edited
Loading

Testing out if some PfC waits can be removed…

Cypress shouldn't assign to return values, see https://docs.cypress.io/guides/references/best-practices#Assigning-Return-Values

Changes

  • Refactor Cypress tests to remove return assignments, which Cypress discourages.
  • Update cypress, eslint-plugin-jsdoc, snyk

How to test this PR

  1. PR checks should pass.

@anselmbradford anselmbradford changed the title Cypress cleanup Minor Cypress cleanup Apr 3, 2024
@anselmbradford anselmbradford marked this pull request as ready for review April 3, 2024 15:08
wpears
wpears approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anselmbradford anselmbradford added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit fddfb03 Apr 3, 2024
11 checks passed
@anselmbradford anselmbradford deleted the ans_cypress_no_assign branch April 3, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpears wpears wpears approved these changes

@mistergone mistergone Awaiting requested review from mistergone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @wpears