Merge pull request #8286 from cfpb/ans_cypress_no_assign

Minor Cypress cleanup

package.json

@@ -45,12 +45,12 @@
     "svg-inline-loader": "0.8.2"
   },
   "devDependencies": {
-    "cypress": "13.7.1",
+    "cypress": "13.7.2",
     "cypress-fail-fast": "7.1.0",
     "eslint": "8.57.0",
     "eslint-config-prettier": "9.1.0",
     "eslint-plugin-import": "2.29.1",
-    "eslint-plugin-jsdoc": "48.2.1",
+    "eslint-plugin-jsdoc": "48.2.2",
     "eslint-plugin-jsx-a11y": "6.8.0",
     "eslint-plugin-react": "7.34.1",
     "jest": "29.7.0",
@@ -59,7 +59,7 @@
     "jest-fetch-mock": "3.0.3",
     "postcss-less": "6.0.0",
     "prettier": "3.2.5",
-    "snyk": "1.1286.1",
+    "snyk": "1.1286.3",
     "stylelint": "16.3.1",
     "stylelint-config-standard": "36.0.0",
     "stylelint-less": "3.0.1"

test/cypress/integration/admin/admin-helpers.cy.js

@@ -212,11 +212,10 @@ export class AdminPage {
   }
 
   clickBlock(name) {
-    const addBlockButton = cy.get(
-      'div[data-contentpath="content"] .c-sf-add-button',
+    cy.get('div[data-contentpath="content"] .c-sf-add-button').should(
+      'be.visible',
     );
-    addBlockButton.should('be.visible');
-    addBlockButton.click();
+    cy.get('div[data-contentpath="content"] .c-sf-add-button').click();
 
     const addTableOption = cy.contains('div.w-combobox__option', name);
     addTableOption.should('be.visible');

test/cypress/integration/paying-for-college/disclosures/disclosures-basics.cy.js

@@ -119,13 +119,10 @@ describe('Dynamic Disclosures', () => {
 
   it('should properly add a private loan on button click', () => {
     page.confirmVerification();
-    const addLoan = cy.get('button.private-loans_add-btn');
     cy.get('.private-loans .private-loans_loan').should('have.length', 1);
-    cy.wait(500);
-    addLoan.click({ force: true });
+    cy.get('button.private-loans_add-btn').click();
     cy.get('.private-loans .private-loans_loan').should('have.length', 2);
-    cy.wait(500);
-    addLoan.click({ force: true });
+    cy.get('button.private-loans_add-btn').click();
     cy.get('.private-loans .private-loans_loan').should('have.length', 3);
   });
 

yarn.lock

@@ -1918,10 +1918,10 @@ [email protected]:
   dependencies:
     chalk "4.1.2"
 
-[email protected].1:
-  version "13.7.1"
-  resolved "https://registry.yarnpkg.com/cypress/-/cypress-13.7.1.tgz#d1208eb04efd46ef52a30480a5da71a03373261a"
-  integrity sha512-4u/rpFNxOFCoFX/Z5h+uwlkBO4mWzAjveURi3vqdSu56HPvVdyGTxGw4XKGWt399Y1JwIn9E1L9uMXQpc0o55w==
+[email protected].2:
+  version "13.7.2"
+  resolved "https://registry.yarnpkg.com/cypress/-/cypress-13.7.2.tgz#61e841382abb20e0a9a063086ee0d850af3ef6bc"
+  integrity sha512-FF5hFI5wlRIHY8urLZjJjj/YvfCBrRpglbZCLr/cYcL9MdDe0+5usa8kTIrDHthlEc9lwihbkb5dmwqBDNS2yw==
   dependencies:
     "@cypress/request" "^3.0.0"
     "@cypress/xvfb" "^1.2.4"
@@ -2421,10 +2421,10 @@ [email protected]:
     semver "^6.3.1"
     tsconfig-paths "^3.15.0"
 
-[email protected].1:
-  version "48.2.1"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-jsdoc/-/eslint-plugin-jsdoc-48.2.1.tgz#9334a05555a95fdc192980627142177963b668b4"
-  integrity sha512-iUvbcyDZSO/9xSuRv2HQBw++8VkV/pt3UWtX9cpPH0l7GKPq78QC/6+PmyQHHvNZaTjAce6QVciEbnc6J/zH5g==
+[email protected].2:
+  version "48.2.2"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-jsdoc/-/eslint-plugin-jsdoc-48.2.2.tgz#eefdc5e3bb3cea957b66dd4817e9de30930b5270"
+  integrity sha512-S0Gk+rpT5w/ephKCncUY7kUsix9uE4B9XI8D/fS1/26d8okE+vZsuG1IvIt4B6sJUdQqsnzi+YXfmh+HJG11CA==
   dependencies:
     "@es-joy/jsdoccomment" "~0.42.0"
     are-docs-informative "^0.0.2"
@@ -5101,10 +5101,10 @@ slice-ansi@^4.0.0:
     astral-regex "^2.0.0"
     is-fullwidth-code-point "^3.0.0"
 
-[email protected].1:
-  version "1.1286.1"
-  resolved "https://registry.yarnpkg.com/snyk/-/snyk-1.1286.1.tgz#981581649567ea9eb36c5ed5238d524892c8f618"
-  integrity sha512-90HXWtJTNrrdcyxgFis5N7EddPmGAE6r/tQuSbaZokzrYb/ziCWDzukiIYLOpUENecdZrNznsT7lcukg6gCaVQ==
+[email protected].3:
+  version "1.1286.3"
+  resolved "https://registry.yarnpkg.com/snyk/-/snyk-1.1286.3.tgz#8304cfa80995ad3ab6505221964b5a27588ea3c8"
+  integrity sha512-SQ7SnJN+9y4IjdCtSVR5/jWi7UtpNf3PElJa72SHBpCOWntQQkQxzyKoPBBE8+3FAJHy7RBJlYNJulMywNDKpw==
   dependencies:
     "@sentry/node" "^7.36.0"
     global-agent "^3.0.0"