Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push nvmeof images to quay on release/tag create #180

Merged
merged 1 commit into from
Aug 30, 2023
Merged

push nvmeof images to quay on release/tag create #180

merged 1 commit into from
Aug 30, 2023

Conversation

barakda
Copy link
Collaborator

@barakda barakda commented Aug 13, 2023

Related to issue174.

Providing a github action to push nvmeof and nvmeof-cli images to the quay.io registries (only) when creating new github releases or tags.

  • github action workflow will run on any new commit (as before) and on a new release/tag add.
  • I checked the push part through my quay.io registry, we need to make sure this repo quay login user/password secrets parameters have the correct values for the production registries.

@caroav caroav requested review from epuertat, oritwas and baum August 13, 2023 07:52
@baum
Copy link
Collaborator

baum commented Aug 14, 2023

@barakda awesome PR! Please sign off the commit, see here, to color DCO check green 🟩.

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also limit this to:

on:
  push:
    tags:
      - 'v*'

Otherwise, any other type of tag name will result in container images being published as well.

.env Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
mk/containerized.mk Outdated Show resolved Hide resolved
mk/containerized.mk Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
mk/containerized.mk Outdated Show resolved Hide resolved
mk/containerized.mk Show resolved Hide resolved
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some final remarks!

Makefile Outdated Show resolved Hide resolved
mk/containerized.mk Outdated Show resolved Hide resolved
mk/containerized.mk Outdated Show resolved Hide resolved
mk/containerized.mk Outdated Show resolved Hide resolved
Signed-off-by: barakda <[email protected]>
@barakda barakda merged commit ec9ffd8 into ceph:devel Aug 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants