Automate container image publishing

[epuertat]

At least on release/tag creation, we should provide a Github action to push containers to the quay.io registry. This could be achieved with the following changes in the current CI action (QUAY_IO_PASSWORD and QUAY_IO_USERNAME have already been added to the Github repo config):

on:
  push:
    ...
    tags:        
      - 'v*'
  ...
      - name: Get subsystems
        run: |
          # https://github.com/actions/toolkit/issues/766
          shopt -s expand_aliases
          eval $(make alias)
          nvmeof-cli get_subsystems
      # If the CI was OK, then let's push the container images
      - name: Publish new containers
        if: startsWith(github.ref, 'refs/tags/v')
        run: |
           docker login -u="${{ vars.QUAY_IO_USERNAME }}" -p="${{ secrets.QUAY_IO_PASSWORD }}"
           make push
   ...

Or this, if we only want to publish containers for releases (and not for every tag):

on:
  release:
    types: [created]
  ...
      # If the CI was OK, then let's push the container images
      - name: Publish new containers
        if: github.event_name == 'release' && github.event.action == 'created'
        run: |
           docker login -u="${{ vars.QUAY_IO_USERNAME }}" -p="${{ secrets.QUAY_IO_PASSWORD }}"
           make push
   ...

This process still requires the manual step of increasing the version number in:

• .env: NVMEOF_VERSION
• pyproject.toml: version

It'd be ideal if we can remove the version literals from those files and dynamically feed the version number from the last git tag with git describe --tag --abbrev=0.

References:

• https://stackoverflow.com/questions/61891328/trigger-github-action-only-on-new-tags
• https://stackoverflow.com/questions/58475748/github-actions-how-to-check-if-current-push-has-new-tag-is-new-release

[caroav]

@barakda this one can be closed?

[barakda]

closing this issue as it was implemented through PR180.