Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: USDC support as first-class citizen #130

Closed
wants to merge 4 commits into from
Closed

Conversation

nicolasbrugneaux
Copy link
Contributor

WIP

This adds support for USDC but it's kinda blocked by a couple things:

Copy link

changeset-bot bot commented Feb 9, 2024

⚠️ No Changeset found

Latest commit: 157556c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Feb 9, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@celo/[email protected] None 0 3.94 MB app-tooling

View full report↗︎

token,
await registryContract.read.getAddressForString(token),
])
['GoldToken', 'StableToken', 'StableTokenEUR', 'StableTokenBRL', 'StableToken$USDC'].map(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, this is not going to work for StableToken$USDC, because USDC will not be a core contract, so won't be in Registry.sol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

righto

@aaronmgdr
Copy link
Member

I think my and marianos thoughts here will be helpful for this work

celo-org/celo-monorepo#10910 (comment)

Commenting further on what i said in meeting today. I think we should start thinking in terms of FeeCurrencyWhitelist rather than StableTokens. (separating what were coupled concepts) we are adding support for tokens because of their inclusion in the whitelist. and in theory not every feecurrencywhitelist token needs to be stable.

So rather than adding the token to existing StableToken enums and objects might be time to do more of a thinking on design.

@nicolasbrugneaux
Copy link
Contributor Author

Closing in favour of #151

@arthurgousset arthurgousset deleted the feat/usdc branch March 21, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants