-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: USDC support as first-class citizen #130
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
token, | ||
await registryContract.read.getAddressForString(token), | ||
]) | ||
['GoldToken', 'StableToken', 'StableTokenEUR', 'StableTokenBRL', 'StableToken$USDC'].map( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken, this is not going to work for StableToken$USDC
, because USDC will not be a core contract, so won't be in Registry.sol
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
righto
I think my and marianos thoughts here will be helpful for this work celo-org/celo-monorepo#10910 (comment) Commenting further on what i said in meeting today. I think we should start thinking in terms of FeeCurrencyWhitelist rather than StableTokens. (separating what were coupled concepts) we are adding support for tokens because of their inclusion in the whitelist. and in theory not every feecurrencywhitelist token needs to be stable. So rather than adding the token to existing StableToken enums and objects might be time to do more of a thinking on design. |
Closing in favour of #151 |
WIP
This adds support for USDC but it's kinda blocked by a couple things:
FeeCurrencyAdapter
isn't out in@celo/abis
yet