Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI and ContractKit support all accepted fee currencies equally, including for transfers and for use as fee currencies #128

Closed
8 tasks done
nicolasbrugneaux opened this issue Feb 8, 2024 · 6 comments
Assignees

Comments

@nicolasbrugneaux
Copy link
Contributor

nicolasbrugneaux commented Feb 8, 2024

Description

copy/paste from Q1 OKRs: cLabs 2024 Q1 Objectives FINAL

USDC first-class developer experience in Celo SDKs

Developer experience

Working backwards from the developer experience to see what SDK changes need to be made.

I'm writing demo scripts for how USDC would be used as a fee currency in celo-org/feecurrency

Viem demo (Recommended)

Tasks

What about celo-ethers-wrapper? Is it worth including that as an option or should we just link to the ethers discussion?

Celo SDK demos (Discouraged)

Tasks

Celo CLI/SDK changes

Tasks

  1. nicolasbrugneaux
@arthurgousset
Copy link
Contributor

Currently working on:

@arthurgousset
Copy link
Contributor

(for future reference)

PR that added cEUR in the past:

We're not planning to use this pattern for USDC, but linking in case it's useful for context.

@arthurgousset arthurgousset changed the title Add circle's USDC in contractkit as first-class citizen Investigate USDC developer experience in Contractkit and CLI as first-class citizen Feb 20, 2024
@arthurgousset arthurgousset changed the title Investigate USDC developer experience in Contractkit and CLI as first-class citizen USDC first-class developer experience in Celo SDKs Feb 21, 2024
@arthurgousset arthurgousset changed the title USDC first-class developer experience in Celo SDKs CLI and ContractKit support all accepted fee currencies equally, including for transfers and for use as fee currencies Feb 21, 2024
@arthurgousset
Copy link
Contributor

arthurgousset commented Feb 21, 2024

Asked to faucet STBLTEST tokens on alfajores for testing

@arthurgousset
Copy link
Contributor

arthurgousset commented Feb 22, 2024

Quickly check fee currencies from the Terminal:

Alfajores:

$ cast call 0xB8641365dBe943Bc2fb6977e6FBc1630EF47dB5a "getWhitelist() (address[] memory)" --rpc-url='https://alfajores-forno.celo-testnet.org'
[0x874069Fa1Eb16D44d622F2e0Ca25eeA172369bC1, 0x10c892A6EC43a53E45D0B916B4b7D383B1b78C0F, 0xE4D517785D091D3c54818832dB6094bcc2744545, 0x03d3daB843e6c03b3d271eff9178e6A96c28D25f, 0xB0FA15e002516d0301884059c0aaC0F0C72b019D, 0xc9cce1e51F1393CE39EB722E3e59eDE6faBf89fD, 0xC4f86E9B4A588D501c1c3e25628dFd50Bc8D615e, 0xDB93874fE111F5a87Acc11Ff09Ee9450Ac6509AE, 0x7d027790998f714B294c96Fda9E27AF586d1EbB5, 0x1aD7b617cB6c5156A6dea6E47514D16476b99F38]

Mainnet:

Call the getWhitelist() function on the FeeCurrencyWhitelist.sol contract deployed at 0xbb024e9cdcb2f9e34d893630d19611b8a5381b3c.

$ cast call 0xbb024e9cdcb2f9e34d893630d19611b8a5381b3c "getWhitelist() (address[] memory)" --rpc-url='https://forno.celo.org'   
[0x765DE816845861e75A25fCA122bb6898B8B1282a, 0xD8763CBa276a3738E6DE85b4b3bF5FDed6D6cA73, 0xe8537a3d056DA446677B9E9d6c5dB704EaAb4787, 0x73F93dcc49cB8A239e2032663e9475dd5ef29A08]

@arthurgousset
Copy link
Contributor

arthurgousset commented Mar 1, 2024

Re demos

I converted all demos from cUSD into STBLTEST fee currency transactions.

  • All demos work ✅
  • The changes are committed ✅
  • The README is updated with usage instructions ✅.

The only thing left here is:

  • to update the demo README and constants.ts with the official USDC token and adapter addresses (once deployed), and
    Image

  • to remove the disclaimer from the README
    Image

  • Any refactoring and improvements to the scripts and/or README you can think of

Re CLI and SDK changes

I pushed all my work in progress changes ✅
I left comments and my personal TODOs in the PR for reference ✅

@arthurgousset
Copy link
Contributor

All good to hand-over from here @nicolasbrugneaux 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants