Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseEntity: remote property was not usable. #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BaseEntity: remote property was not usable. #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/MilkCheck/Engine/BaseEntity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,8 @@ def inherits_from(self, entity):
if self.target is None:
self.target = entity.target
self.mode = self.mode or entity.mode
self.remote = self.remote and entity.remote
if self.remote is None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not possible. Default remote value is True. So it will never be None. This test is always false.

Could you add a test to show the problem you're trying to solve?

self.remote = entity.remote
if self.desc is None:
self.desc = entity.desc
self.delay = self.delay or entity.delay
Expand Down