BaseEntity: remote property was not usable. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we could set a remote property (Boolean) but it was rewriten in BaseEntity's inherits_from with the result of a comparison of a Boolean and a NoneType. Thus, we could only set remote to True, because 'False or None' evaluates to None, which is the default value. Now, we can set the remote property to False and use the functionality it unveils within ClusterShell.
degremont
requested changes
Feb 13, 2018
| @@ -693,7 +693,8 @@ def inherits_from(self, entity): | |||
| if self.target is None: | |||
| self.target = entity.target | |||
| self.mode = self.mode or entity.mode | |||
| self.remote = self.remote and entity.remote | |||
| if self.remote is None: | |||
There was a problem hiding this comment.
This is not possible. Default remote value is True. So it will never be None. This test is always false.
Could you add a test to show the problem you're trying to solve?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we could set a remote property (Boolean) but it was rewriten
in BaseEntity's inherits_from with the result of a comparison of a
Boolean and a NoneType. Thus, we could only set remote to True, because
'False or None' evaluates to None, which is the default value.
Now, we can set the remote property to False and use the functionality
it unveils within ClusterShell.