Feature/evm reader multi dapp #512

fmoura · 2024-07-09T16:48:59Z

Closes #332

To manually test EVM Reader Standalone first you need to build Devnet. In a terminal, type:

make docker-build-deps

then start the dependencies

go run ./cmd/cartesi-rollups-cli/ run-deps

setup the database. Open a new terminal and type:

go run ./cmd/cartesi-rollups-cli/ db upgrade

then, setup envrironment variables

source ./setup_env.sh

and finally start EVM Reader

go run ./cmd/cartesi-rollups-evm-reader/ --verbose

Now to "interact" with it, add aplications

go run ./cmd/cartesi-rollups-cli/ app add -a 0x2E663fe9aE92275242406A185AA4fC8174339D3E  -n 16

-a parameter sets the application address and -n is Inputbox Deployment block number

To send inputs use something like:

go run ./cmd/cartesi-rollups-cli/ send --address-book ./addresses.json --payload "0xdeadbeef"

where addresses.json is a addresses.json file, where you can set the application contract you want

internal/evmreader/evmreader.go

internal/evmreader/evmreader_test.go

marcelstanley

Approved with some suggestions to be addressed later on.

marcelstanley · 2024-07-19T14:22:56Z

cmd/cartesi-rollups-cli/root/db/check/check.go

+	Run:   run,
+}
+
+func run(cmd *cobra.Command, args []string) {


We may need to improve this command.
In the sequence below, there's:

an upgrade

check for version 2

check for version 3

rollups-node$ go run ./cmd/cartesi-rollups-cli/ db upgrade Database Schema successfully Updated. Current version is 2 rollups-node$ rollups-node$ go run ./cmd/cartesi-rollups-cli/ db check-version 2 Database Schema is at the correct version: 2 rollups-node$ rollups-node$ go run ./cmd/cartesi-rollups-cli/ db check-version 3 Database Schema is at the correct version: 2 rollups-node$

Also, message Database Schema successfully Updated. Current version is 2 should be similar to what cobra.CheckErr(err) responds (Error: No valid database schema found).

Check-version do not receive arguments. It only check is the DB is at the expected version.

marcelstanley · 2024-07-19T14:42:39Z

cmd/cartesi-rollups-evm-reader/main.go

+var (
+	// Should be overridden during the final release build with ldflags
+	// to contain the actual version number
+	buildVersion = "devel"


buildVersion should be held elsewhere in a common place that could be shared by all binaries we provide. Se also these places

marcelstanley · 2024-07-19T14:46:02Z

cmd/cartesi-rollups-evm-reader/main.go

+	// Validate Schema
+	err := startup.ValidateSchema(c.PostgresEndpoint.Value)
+	if err != nil {
+		slog.Error("EVM Reader exited with an error", "error", err)
+		os.Exit(1)
+	}
+
+	database, err := repository.Connect(ctx, c.PostgresEndpoint.Value)
+	if err != nil {
+		slog.Error("EVM Reader couldn't connect to the database", "error", err)
+		os.Exit(1)
+	}
+	defer database.Close()
+
+	_, err = startup.SetupNodePersistentConfig(ctx, database, c)
+	if err != nil {
+		slog.Error("EVM Reader couldn't connect to the database", "error", err)
+		os.Exit(1)
+	}


This could generalized to be used in all necessary commands, including cartesi-rollups-node.

I created the "startup" package for that. This can indeed further improved, making all "node binaries" similar

Perhaps we could go one step further and perform all these steps in on shot there, then.

marcelstanley · 2024-07-19T14:48:43Z

docs/cli/cartesi-rollups-cli_app.md

@@ -0,0 +1,17 @@
+## cartesi-rollups-cli app


Perhaps we could add an HTML disclaimer to all generated MD files (via gen-docs) warning they were generated like we do with the automatically generated code.

internal/evmreader/evmreader.go

marcelstanley · 2024-07-19T15:07:55Z

internal/util/retrypolicy/retry.go

+	for i := uint64(0); i <= maxRetries; i++ {
+		lastValue, lastErr = fn(args)
+		if lastErr == nil {
+			return lastValue, nil


We are missing an INFO log for a successful execution.

marcelstanley · 2024-07-19T15:10:07Z

internal/evmreader/inputsource_adapter.go

+	InputBox = inputbox.InputBox
+)
+
+// InputBox Wrapper


Improve docs.

marcelstanley · 2024-07-19T15:13:32Z

internal/evmreader/evmreader_test.go

+// Service tests
+func (s *EvmReaderSuite) TestItStopsWhenContextIsCanceled() {
+	ctx, cancel := context.WithCancel(s.ctx)
+	ready := make(chan struct{}, 1)
+	errChannel := make(chan error, 1)
+	go func() {
+		errChannel <- s.evmReader.Run(ctx, ready)
+	}()
+	cancel()
+
+	err := <-errChannel
+	s.Require().Equal(context.Canceled, err, "stopped for the wrong reason")
+}
+
+func (s *EvmReaderSuite) TestItEventuallyBecomesReady() {
+	ready := make(chan struct{}, 1)
+	errChannel := make(chan error, 1)
+	go func() {
+		errChannel <- s.evmReader.Run(s.ctx, ready)
+	}()
+
+	select {
+	case <-ready:
+	case err := <-errChannel:
+		s.FailNow("unexpected failure", err)
+	}
+}


I did this but, on hindsight, I think we should generalize these tests and move them to https://github.com/cartesi/rollups-node/tree/next/2.0/internal/services

marcelstanley · 2024-07-19T15:14:28Z

internal/evmreader/evmreader_test.go

+	s.client.AssertNumberOfCalls(s.T(), "SubscribeNewHead", 1)
+}
+
+func (s *EvmReaderSuite) TestItReadsInputsFromNewBlocks() {


Add tests covering more than one application at a time.

marcelstanley · 2024-07-19T15:26:48Z

internal/evmreader/evmreader.go

+		currentMostRecentFinalizedHeader, err := r.fetchMostRecentHeader(
+			ctx,
+			r.config.DefaultBlock,
+		)
+		if err != nil {
+			slog.Error("Error fetching most recent block",
+				"last default block",
+				r.config.DefaultBlock,
+				"error",
+				err)
+			continue
+		}
+		currentMostRecentFinalizedBlockNumber := currentMostRecentFinalizedHeader.Number.Uint64()
+


Shouldn't this whole block be moved outside the loop for groupedApps (BTW, appGroup would be better) to retrieve currentMostRecentFinalizedBlockNumber only once and share it between apps?

fmoura added this to the 2.0.0 milestone Jul 9, 2024

fmoura self-assigned this Jul 9, 2024

fmoura force-pushed the feature/evm-reader-muilti-dapp branch 3 times, most recently from 2bbef0b to 984437c Compare July 9, 2024 17:37

fmoura added the #feat:evm-reader Feature: evm reader label Jul 9, 2024

fmoura force-pushed the feature/evm-reader-muilti-dapp branch 2 times, most recently from 0b20cf4 to 9839466 Compare July 9, 2024 19:46

fmoura changed the title ~~Feature/evm reader muilti dapp~~ Feature/evm reader multi dapp Jul 9, 2024

This was referenced Jul 9, 2024

Feature/input reader retry requests #508

Closed

feat(input-reader):create input-reader #451

Closed

GMKrieger force-pushed the feature/multi-dapp-repository branch from c44553c to ed637c6 Compare July 9, 2024 20:07

fmoura force-pushed the feature/evm-reader-muilti-dapp branch from 9839466 to caee21b Compare July 9, 2024 20:12

GMKrieger force-pushed the feature/multi-dapp-repository branch from ed637c6 to 217c97d Compare July 9, 2024 20:25

fmoura force-pushed the feature/evm-reader-muilti-dapp branch 2 times, most recently from cf24743 to 426abc3 Compare July 9, 2024 20:53

GMKrieger force-pushed the feature/multi-dapp-repository branch 2 times, most recently from 20ad909 to 8c701de Compare July 10, 2024 11:12

fmoura force-pushed the feature/evm-reader-muilti-dapp branch from 426abc3 to f9c9a73 Compare July 10, 2024 13:01

GMKrieger force-pushed the feature/multi-dapp-repository branch 2 times, most recently from a376638 to 23825d2 Compare July 10, 2024 14:53

fmoura force-pushed the feature/evm-reader-muilti-dapp branch from f9c9a73 to f62bf70 Compare July 10, 2024 15:13

GMKrieger force-pushed the feature/multi-dapp-repository branch 5 times, most recently from d9f780e to 62bd20e Compare July 10, 2024 18:25

fmoura force-pushed the feature/evm-reader-muilti-dapp branch 3 times, most recently from 4ebb51e to 70ce3b9 Compare July 11, 2024 04:23

fmoura force-pushed the feature/evm-reader-muilti-dapp branch 3 times, most recently from ad1b09b to b7bbd22 Compare July 18, 2024 19:34

vfusco requested changes Jul 18, 2024

View reviewed changes

internal/evmreader/evmreader.go Show resolved Hide resolved

internal/evmreader/evmreader.go Outdated Show resolved Hide resolved

internal/evmreader/evmreader.go Outdated Show resolved Hide resolved

fmoura force-pushed the feature/evm-reader-muilti-dapp branch 2 times, most recently from 26946c6 to 5fa5fc6 Compare July 18, 2024 20:12

fmoura requested review from GMKrieger, marcelstanley, vfusco and tuler July 18, 2024 20:15

marcelstanley reviewed Jul 18, 2024

View reviewed changes

internal/evmreader/evmreader_test.go Outdated Show resolved Hide resolved

fmoura force-pushed the feature/evm-reader-muilti-dapp branch from 022a767 to 213981b Compare July 19, 2024 00:00

GMKrieger previously approved these changes Jul 19, 2024

View reviewed changes

fmoura dismissed GMKrieger’s stale review via 2a8499e July 19, 2024 01:15

fmoura added 8 commits July 19, 2024 11:14

feat(util): Add retry policy utility function

33dcbb3

feat(cli): Add disable postgres or devnet to run-deps

486c8c7

feat(cli): Add add and list applications commands

2a7f934

feat(cli): Add check-version and upgrade schema commands

fc1b539

feat(evm-reader): Add evm-reader

e0bf69d

feat(evm-reader): Add evm-reader tests

deaf2f1

feat(evm-reader): Add evm-reader command

fe795bc

chore: fix Dockerfile non matching case

e7f2563

fmoura force-pushed the feature/evm-reader-muilti-dapp branch from a4d6e2e to e7f2563 Compare July 19, 2024 14:14

vfusco approved these changes Jul 19, 2024

View reviewed changes

GMKrieger approved these changes Jul 19, 2024

View reviewed changes

fmoura merged commit e7f2563 into next/2.0 Jul 19, 2024
6 checks passed

fmoura deleted the feature/evm-reader-muilti-dapp branch July 19, 2024 15:25

marcelstanley approved these changes Jul 19, 2024

View reviewed changes

marcelstanley mentioned this pull request Aug 2, 2024

Implement Input Reader database functionalities #349

Closed

2 tasks

GMKrieger mentioned this pull request Aug 8, 2024

Create new tests for evm reader repository #497

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/evm reader multi dapp #512

Feature/evm reader multi dapp #512

fmoura commented Jul 9, 2024 •

edited

Loading

marcelstanley left a comment

marcelstanley Jul 19, 2024

fmoura Jul 19, 2024

marcelstanley Jul 19, 2024

marcelstanley Jul 19, 2024

fmoura Jul 19, 2024

marcelstanley Jul 19, 2024

marcelstanley Jul 19, 2024 •

edited

Loading

marcelstanley Jul 19, 2024

marcelstanley Jul 19, 2024

marcelstanley Jul 19, 2024

marcelstanley Jul 19, 2024

marcelstanley Jul 19, 2024

Feature/evm reader multi dapp #512

Feature/evm reader multi dapp #512

Conversation

fmoura commented Jul 9, 2024 • edited Loading

marcelstanley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcelstanley Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fmoura commented Jul 9, 2024 •

edited

Loading

marcelstanley Jul 19, 2024 •

edited

Loading