feat(input-reader):create input-reader #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoura
force-pushed
the
feature/go-input-reader
branch
from
00c374d
to
f8093aa
Compare
fmoura
force-pushed
the
feature/go-input-reader
branch
2 times, most recently
from
94a4f06
to
4605516
Compare
GMKrieger
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Most of the code seems fine, although I couldn't run the tests on my machine
There are only 2 major comments:
- All of the json files are either missing the EOF linebreak or have 4+ lines at the end
- There should be multiple commits, as Marcel mentioned. IMHO, there should be a commit for the cli changes, one for the ethutil changes, one for the input reader and one for the tests
fmoura
force-pushed
the
feature/go-input-reader
branch
2 times, most recently
from
820719d
to
877a484
Compare
|
Created PR #455 with cli commits |
2 tasks
fmoura
force-pushed
the
feature/go-input-reader
branch
2 times, most recently
from
755dbf5
to
a2bef82
Compare
fmoura
force-pushed
the
feature/go-input-reader
branch
3 times, most recently
from
8abe038
to
7055d7a
Compare
GMKrieger
force-pushed
the
feature/input-reader-repository
branch
3 times, most recently
from
b50aabb
to
666ca30
Compare
fmoura
force-pushed
the
feature/go-input-reader
branch
2 times, most recently
from
8ff7cdc
to
f79d59f
Compare
fmoura
force-pushed
the
feature/go-input-reader
branch
2 times, most recently
from
0521ffb
to
d8dbe82
Compare
GMKrieger
force-pushed
the
feature/input-reader-repository
branch
2 times, most recently
from
b1abbba
to
3c8e869
Compare
fmoura
force-pushed
the
feature/go-input-reader
branch
3 times, most recently
from
ec7e240
to
6122d59
Compare
fmoura
force-pushed
the
feature/go-input-reader
branch
from
6122d59
to
6d264b4
Compare
This was
linked to
issues
Jul 4, 2024
Closed
|
This is being deprecated in favor of #512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.