-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add java client #20
Conversation
490ace3
to
434a37c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handling policy id prefix stackable/bundles/
seems inconsistent and inconvenient. Why not leaving it to the service at all?
if (index == 0) { | ||
commonPolicies.addAll(result._2.get()); | ||
} else { | ||
commonPolicies.retainAll(result._2.get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ignored if at least one provider has policies defined that are not present on other(s).
Should that be logged somehow? Is this considered okay?
It could be a common scenario if policies are updated (added or deleted) and changes are not yet reflected on all VCPs. However, an option to have this information printed allows debugging if policies are not enrolled properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now logged on debug level.
08967db
to
ff1da62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
ff1da62
to
46c625f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.