feat: initial implementation of OPA subsystem chart and policy catalogue #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
The following things have to be done before this PR can be merged:
|
strieflin
force-pushed
the
add-policy-subsystem
branch
from
3cd6811 to
caaf657
Compare
Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
…ces package) Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
strieflin
force-pushed
the
add-policy-subsystem
branch
from
f8f9f0e to
ad388d1
Compare
strieflin
changed the title
Signed-off-by: Sven Trieflinger <[email protected]>
strieflin
force-pushed
the
add-policy-subsystem
branch
from
0564d21 to
330347f
Compare
Signed-off-by: Sven Trieflinger <[email protected]>
sbckr
requested changes
Nov 13, 2024
services/pkg/catalogue/opa.go
Outdated
| } | ||
|
|
||
| // fetchPolicyFromOPA fetches a single policy from the OPA service by its ID. | ||
| // Note that there is no way to fetch a single policy by ID, so we fetch all. |
There was a problem hiding this comment.
but one could simply call v1/policies/<POLICY_ID>
There was a problem hiding this comment.
Don't know how I have missed that. Used now.
sbckr
reviewed
Nov 13, 2024
|
|
||
| switch c.GetHeader("Accept") { | ||
| case "application/json": | ||
| c.JSON(http.StatusOK, policy) |
There was a problem hiding this comment.
why are ID's encoded when listing, but not when fetching individually. That's kinda inconsistent
There was a problem hiding this comment.
Correct. The ID is now consistently encoded.
Signed-off-by: Sven Trieflinger <[email protected]>
Signed-off-by: Sven Trieflinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.