feat: Skip landscape page #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is quite a large commit since there are a lot of moving pieces. The existing Landscape page needs its skip functionality removed, the skip page uses an updated version of copy, the skip page uses an entirely new layout, etc. I plan on expanding the use of reusable navigation and other layout widgets since the new designs will be much more consistent across pages.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
+ Coverage 89.20% 89.40% +0.20%
==========================================
Files 110 113 +3
Lines 7520 7618 +98
==========================================
+ Hits 6708 6811 +103
+ Misses 633 631 -2
+ Partials 179 176 -3 ☔ View full report in Codecov by Sentry. |
Also modifies the existing test for the SubscribeNow page's launcher to unify the launcher mocks.
CarlosNihelton
requested changes
Dec 9, 2024
gui/packages/ubuntupro/lib/pages/landscape_skip/landscape_skip_page.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/test/pages/landscape_skip/landscape_page_test.dart
Outdated
Show resolved
Hide resolved
This was referenced Dec 10, 2024
CarlosNihelton
approved these changes
Dec 11, 2024
ashuntu
added a commit
that referenced
this pull request
Dec 11, 2024
Adds a border to the radio tiles, as well as a background to unselected tiles. | | Dark | Light | |-|------|-------| | Existing |  |  | | New |  |  | This is also based on #997 and relies on it being merged first. --- UDENG-5593
ashuntu
added a commit
that referenced
this pull request
Dec 17, 2024
Restructures the Landscape page to use the 2 column layout. This comes with quite the large side effect of combining the SaaS and self-hosted configurations into a single set of fields, so there are quite a lot of changes here to support that.  *This is based on and relies on #997 being merged first.* --- UDENG-5288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a fairly large PR since there are a few moving pieces to adding this page. The existing Landscape page needs its skip functionality removed, the skip page uses an updated version of copy, the skip page uses an entirely new layout, etc.
I plan on expanding the use of reusable navigation and other layout widgets since the new designs will be much more consistent across pages. Notably, when I reorganize the Landscape page, we can unify a lot of the navigation and tile widgets.
UDENG-5287