Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reorganize landscape page #1008

Merged
merged 12 commits into from
Dec 17, 2024
Merged

feat: Reorganize landscape page #1008

merged 12 commits into from
Dec 17, 2024

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Dec 10, 2024

Restructures the Landscape page to use the 2 column layout. This comes with quite the large side effect of combining the SaaS and self-hosted configurations into a single set of fields, so there are quite a lot of changes here to support that.

image

This is based on and relies on #997 being merged first.


UDENG-5288

@ashuntu ashuntu self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 88.60759% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (d5ce322) to head (a20d697).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
.../ubuntupro/lib/pages/landscape/landscape_page.dart 83.63% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   89.38%   89.20%   -0.19%     
==========================================
  Files         113      113              
  Lines        7618     7528      -90     
==========================================
- Hits         6809     6715      -94     
- Misses        632      637       +5     
+ Partials      177      176       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This collapses the SaaS and custom configuration into one set of fields, and shows all fields at the same time.
No logic or UI changes here, just renaming variables.
@ashuntu ashuntu force-pushed the organize-landscape-page branch from c15d876 to bb8ed80 Compare December 11, 2024 18:03
@ashuntu ashuntu marked this pull request as ready for review December 11, 2024 20:44
@ashuntu ashuntu requested a review from a team as a code owner December 11, 2024 20:44
@ashuntu
Copy link
Collaborator Author

ashuntu commented Dec 11, 2024

This probably has a ways to go before it is ready, but I opened for review so we can get started on back and forth :)

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's focus on the models first.
The current design mockups are essentially removing the "support" we had implemented in code for the Landscape SaaS, instead of merging it with the self-hosted option. You can rename it to manual, as you did, but it cannot be made to work with Landscape SaaS at all at this moment.
If my comments are not clear enough let's pair together on this tomorrow.

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive wok on the UI changes! I just have one minor UX concern. We're almost there.

An unncessary check creates an issue where if there was a FQDN error, it takes 2 updates to the FQDN to get rid of the error instead of 1.
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🎉

@ashuntu ashuntu merged commit 6cb43e3 into main Dec 17, 2024
36 checks passed
@ashuntu ashuntu deleted the organize-landscape-page branch December 17, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants