-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reorganize landscape page #1008
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 89.38% 89.20% -0.19%
==========================================
Files 113 113
Lines 7618 7528 -90
==========================================
- Hits 6809 6715 -94
- Misses 632 637 +5
+ Partials 177 176 -1 ☔ View full report in Codecov by Sentry. |
This collapses the SaaS and custom configuration into one set of fields, and shows all fields at the same time.
No logic or UI changes here, just renaming variables.
c15d876
to
bb8ed80
Compare
This probably has a ways to go before it is ready, but I opened for review so we can get started on back and forth :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's focus on the models first.
The current design mockups are essentially removing the "support" we had implemented in code for the Landscape SaaS, instead of merging it with the self-hosted option. You can rename it to manual, as you did, but it cannot be made to work with Landscape SaaS at all at this moment.
If my comments are not clear enough let's pair together on this tomorrow.
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/test/pages/landscape/landscape_data_model_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive wok on the UI changes! I just have one minor UX concern. We're almost there.
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/test/pages/landscape/landscape_data_model_test.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
An unncessary check creates an issue where if there was a FQDN error, it takes 2 updates to the FQDN to get rid of the error instead of 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! 🎉
Restructures the Landscape page to use the 2 column layout. This comes with quite the large side effect of combining the SaaS and self-hosted configurations into a single set of fields, so there are quite a lot of changes here to support that.
This is based on and relies on #997 being merged first.
UDENG-5288