Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui-ubuntupro): Remove popup feedback when applying a token #967

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Nov 19, 2024

Removes the popup as well as the test that asserts its existence. The tests for the pro token field that already exist should be enough to test error functionality.


UDENG-5286

Removes the popup as well as the test that asserts its existence. The tests for the pro token field that already exist should be enough to test error functionality.
@ashuntu ashuntu self-assigned this Nov 19, 2024
@ashuntu ashuntu changed the title Remove popup feedback when applying a token fix: Remove popup feedback when applying a token Nov 19, 2024
@ashuntu ashuntu changed the title fix: Remove popup feedback when applying a token fix(gui-ubuntupro): Remove popup feedback when applying a token Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (c6c1db5) to head (93c7c1e).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   89.15%   89.09%   -0.06%     
==========================================
  Files         110      110              
  Lines        7506     7502       -4     
==========================================
- Hits         6692     6684       -8     
- Misses        633      637       +4     
  Partials      181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ashuntu ashuntu marked this pull request as ready for review November 19, 2024 21:52
@ashuntu ashuntu requested a review from a team as a code owner November 19, 2024 21:52
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap! Straight to the point!

@ashuntu ashuntu merged commit 4ddcbb6 into main Nov 21, 2024
35 checks passed
@ashuntu ashuntu deleted the remove-token-popup branch November 21, 2024 15:06
ashuntu added a commit that referenced this pull request Nov 21, 2024
This happened because #967 removed a test that was no longer needed (as
well as this import), but was not removed in main before the branch for
#968 was created. Since the import had to change for the relocation of
common tokens, git didn't merge the changes quite correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants