Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove accidental inclusion of an unused import #978

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Nov 21, 2024

This happened because #967 removed a test that was no longer needed (as well as this import), but was not removed in main before the branch for #968 was created. Since the import had to change for the relocation of common tokens, git didn't merge the changes quite correctly.

@ashuntu ashuntu self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (bacd87c) to head (dbc63f8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   87.97%   89.09%   +1.12%     
==========================================
  Files          88      110      +22     
  Lines        6528     7494     +966     
==========================================
+ Hits         5743     6677     +934     
- Misses        604      636      +32     
  Partials      181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ashuntu ashuntu marked this pull request as ready for review November 21, 2024 17:39
@ashuntu ashuntu requested a review from a team as a code owner November 21, 2024 17:39
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@ashuntu ashuntu merged commit 3c18161 into main Nov 21, 2024
36 checks passed
@ashuntu ashuntu deleted the remove-unused-import branch November 21, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants