Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui): Replaces placeholder text by real copy #407

Merged
merged 2 commits into from
Nov 20, 2023
Merged

fix(gui): Replaces placeholder text by real copy #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aeb964
Replaces placeholder text by real copy
CarlosNihelton Nov 16, 2023
362f0a6
Updates end to end test "script"
CarlosNihelton Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gui/packages/ubuntupro/end_to_end/end_to_end_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Future<void> testManualTokenInput(WidgetTester tester) async {

// asserts that we transitioned to the user-managed status page.
l10n = tester.l10n<SubscriptionStatusPage>();
expect(find.text(l10n.manuallyManaged), findsOneWidget);
expect(find.text(l10n.detachPro), findsOneWidget);
}

Future<void> testPurchase(WidgetTester tester) async {
Expand Down
9 changes: 8 additions & 1 deletion gui/packages/ubuntupro/lib/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,14 @@
"storeManaged": "This subscription is managed through Microsoft Store",
"manageSubscription": "Manage your subscription",
"orgManaged": "This subscription is owned and managed by your company",
"manuallyManaged": "Lorem ipsum...",
"manuallyManaged": "Visit {proDashboardLink} to manage your subscription.",
"@manuallyManaged": {
"placeholders": {
"proDashboardLink": {
"type": "String"
}
}
},
"detachPro": "Detach Pro",

"updatingSubscriptionInfo": "Updating the subscription information.",
Expand Down
2 changes: 1 addition & 1 deletion gui/packages/ubuntupro/lib/pages/subscription_status/subscription_status_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class SubscriptionStatusPage extends StatelessWidget {
),
),
UserSubscriptionStatusModel() => SubscriptionStatus(
caption: lang.manuallyManaged,
caption: lang.manuallyManaged('ubuntu.com/pro/dashboard'),
actionButton: FilledButton(
style: FilledButton.styleFrom(
backgroundColor: const Color(0xFFE86581),
Expand Down
Loading