fix(gui): Replaces placeholder text by real copy #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliver suggested that text during the Engineering Sprint. Ideally that should be clickable. But let's not invest too much now because Elio is overhauling those screens. As a consequence I'll have to rewrite most of the Flutter UI code (the *_page.dart and *_widgets.dart files) The parameterized l10n string, though, will be used in the final screen.
EduardGomezEscandell
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oliver suggested the replacement text during the Engineering Sprint.
Ideally the link should be clickable, but let's not invest too much now because Elio is overhauling those screens.
As a consequence I'll have to rewrite most of the Flutter UI code (the *_page.dart and *_widgets.dart files) anyway.
The parameterized l10n string, though, will be useful for the final screen.
This is how it looks like with the proposed changes in place:
With the changes from the Design Team (the copy with the hyperlink is not yet present in Figma):
